On Mon Oct 2 21:48:01 2023 +0000, Henri Verbeet wrote:
No objections from me, but since Francisco is working on this it's
appropriate to have a green light from him too. In general sure, but I think this is straightforward. I'd suggest using uint32_t though, because this is a mask. More broadly, the only places in vkd3d that should use Windows types like DWORD are places where those are dictated by the API we're implementing; for vkd3d-shader that's essentially nowhere. (Because things like DWORD don't have a consistent definition between the Linux and the Windows build. We want to address that, but avoiding these types avoids the issue, and there should be few places that actually require them.)
At first I was worried about changing `vkd3d_shader_dst_param.write_mask` from DWORD to uint32_t, but your comment implies that it is okay to change them to uint32_t, so I think the change is okay.
There are several other fields in vkd3d_shader_dst_param and vkd3d_shader_src_param that also use DWORD though, should I write patches to replace those?