Re: [PATCH v2 0/5] MR8490: d3dx{9,10}: Beginnings of d3dx code sharing.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/d3dx_helpers.c:
> -
>    src_bytes_left -= rle_packet_size;
> -
>    pixel_count += rle_count;
> -
>    if (!src_bytes_left && pixel_count != row_width)
> -
>        return D3DXERR_INVALIDDATA;
> - }
> -
> - *src = src_ptr;
> - return D3D_OK;
>
> +}
> -
>
> +struct d3dx_color_key;
> +static void convert_argb_pixels(const BYTE *src, UINT src_row_pitch, UINT src_slice_pitch, const struct volume *src_size,
> -
>    const struct pixel_format_desc *src_format, BYTE *dst, UINT dst_row_pitch, UINT dst_slice_pitch,
> -
>    const struct volume *dst_size, const struct pixel_format_desc *dst_format, const struct d3dx_color_key *color_key,
> -
>    const PALETTEENTRY *palette);
>
> +static HRESULT d3dx_image_tga_decode(const void *src_data, uint32_t src_data_size, uint32_t src_header_size,

We could probably add a blank line above the `d3dx_image_tga_decode()` definition while at it.