Re: [PATCH v3 0/6] MR6688: d3dx9: Move targa decoding into d3dx9, part 2.

[Connor McAdams (＠cmcadams)]

On Fri Oct 18 11:59:18 2024 +0000, Matteo Bruni wrote:
> Maybe I'm misunderstanding the comment but, looking at the existing
> tests, that doesn't seem to be the case? Even in the most recent TGA
> tests there are a number of expected failures with
> `D3DXGetImageInfoFromFileInMemory()` when the data size is too small.
> Orthogonally, it might be better to write it like "D3DXGetImageInfo*()"
> or similar, to avoid possible confusion.

I see what you mean here, I've changed the comment to hopefully clarify things :) what I meant to say was that `D3DXGetImageInfoFromFileInMemory()` only validates the header size, but when loading image data the size of the image itself is also validated.