Hans Leidekker (@hans) commented about dlls/advapi32/tests/crypt.c:
- BOOL result;
- HCRYPTPROV hProv;
- HCRYPTKEY hkey = 0;
- /* When verifying logins in "Marvel Heroes", the application passes garbage data
* in a reserved field that should always be 0 (according to documentation).
*
* This doesn't lead to any error on Windows.
*/
- result = CryptAcquireContextA(&hProv, 0, 0, PROV_RSA_AES, CRYPT_VERIFYCONTEXT);
- ok (result, "%08lx\n", GetLastError());
- if (!result) return;
- /* Looks like native handles are just pointers. */
- ok(!!*(void **)hProv, "Got zero *(void **)hProv.\n");
You're testing an implementation detail of CryptAcquireContextA() here which belongs somewhere else, if it's relevant at all. Otherwise this patch looks good, thanks!