On Tue Jul 2 23:31:06 2024 +0000, Paul Gofman wrote:
My main goal (for this entire MR) is to shut up that MESSAGE for Z:.
Judging by commit 4907f262, the goal is to print that only if the device is a mounted ISO file or an actual optical drive. Let's check for specifically that. It certainly doesn't worth to do a lot of things to get rid of a message in the log. I personally doubt shutting it up is too much useful, but maybe that is just me. If this has to be done it is better not to build up heuristics about that but rather make it a FIXME (so it doesn't show up with WINEDEBUG=-all), or WARN or remove it. But anything without building the whole framework around that or otherwise complicating things. But note that the output is needed for debugging only, the best and only sane way to make it silent is to redirect stderr to /dev/null.
The message shows up if I start some random program in Wine that just wants to show the label somewhere (like GetOpenFileName), or if the program just wants other information (for example https://github.com/mirror/make/blob/d66a65ad5a0e31b287f53930b0f09e31801f1613...).
Having to add WINEDEBUG to every program with a file dialog sounds tedious, so I would quite appreciate changing it somehow.
But you're right, that volume_label_warn variable wasn't the best idea I've had. I can drop the message completely if you'd prefer that, but mac doesn't run dbus, so I suspect the warning still has a few usecases.