On Tue Nov 21 13:23:54 2023 +0000, Rémi Bernon wrote:
Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/4102 /cc @afrantzis Fwiw I didn't use wl_list like suggested in !4102. I think we should prefer `struct list` everywhere possible, which is more convenient, and canonical in Wine (for instance I didn't find `list_add_tail` equivalent).
I am fine either way, the two are virtually identical. If the preference is to use `struct list` then I think we should update the whole driver accordingly, for consistency. I can take care of this in another MR.
---
FWIW, to add to the tail: `wl_list_insert(list->prev, ...)`
I do find `wl_list` to be bit more convenient, because it doesn't need an explicit element type in the various iteration macros:
``` wl_list_for_each(elem, list, link) vs LIST_FOR_EACH(elem, list, struct elem, entry) ```
But `struct list` being canonical for Wine certainly trumps such concerns.