Re: [PATCH v2 0/1] MR8999: win32u: Fix garbled 24-bit bitmap rendering

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/win32u/opengl.c:
>      if (!get_image_from_bitmap( bmp, info, &bits, &src ))
>      {
> -
>        int width = info->bmiHeader.biWidth, height = info->bmiHeader.biSizeImage / 4 / width;
> -
>        if (write) funcs->p_glDrawPixels( width, height, GL_BGRA, GL_UNSIGNED_BYTE, bits.ptr );
> -
>        else funcs->p_glReadPixels( 0, 0, width, height, GL_BGRA, GL_UNSIGNED_BYTE, bits.ptr );
> -
>        int width = info->bmiHeader.biWidth, height = abs( info->bmiHeader.biHeight );
> -
>        UINT format = (info->bmiHeader.biBitCount == 24 ? GL_BGR : GL_BGRA);
> -
>        if (write) funcs->p_glDrawPixels( width, height, format, GL_UNSIGNED_BYTE, bits.ptr );
> -
>        else funcs->p_glReadPixels( 0, 0, width, height, format, GL_UNSIGNED_BYTE, bits.ptr );

I believe there was a buffer overflow as GL / GDI currently don't agree on whether the bitmap is 16bpp or 32bpp, and `height = info->bmiHeader.biSizeImage / 4 / width` was there to avoid reading / writing past the bitmap buffer. This would probably be fixed with your other 16bpp changes, can we keep it for now or is it part of the fix here?