Re: [PATCH v2 0/1] MR8237: kernelbase: Implement HeapSummary

[Vibhav Pant (＠vibhavp)]

Vibhav Pant (@vibhavp) commented about dlls/kernelbase/memory.c:
> }
>
> +/***********************************************************************
> -
> -
>       HeapSummary   (kernelbase.@)
> - */
>
> +BOOL WINAPI HeapSummary( HANDLE heap, DWORD flags, LPHEAP_SUMMARY heap_summary )
> +{
> - SIZE_T allocated = 0;
> - SIZE_T committed = 0;
> - SIZE_T uncommitted = 0;
> - PROCESS_HEAP_ENTRY entry;
> -
> - if (heap_summary->cb != sizeof(*heap_summary))
> -
>    return FALSE; /* needs to be set to the exact size by the caller */

Does HeapSummary not set an error code with SetLastError? The documentation doesnt suggest any error code, but it might be helpful to make sure and test for them if it actually does so in practice.