Re: [PATCH v2 0/6] MR3810: winegstreamer: Implement add_stream and push_sample for muxer.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/wg_muxer.c:
> - if (stream->parser)
> - {
> -
>    link_ok = gst_bin_add(GST_BIN(muxer->container), stream->parser)
> -
>            && link_src_to_element(stream->my_src, stream->parser)
> -
>            && link_element_to_sink(stream->parser, muxer_sink_pad);
> - }
> - else
> - {
> -
>    link_ok = !link_src_to_sink(stream->my_src, muxer_sink_pad);
> - }
> - gst_object_unref(muxer_sink_pad);
> - if (!link_ok)
> -
>    return false;
> -
> - /* Active pad and push events to prepare for streaming. */
> - sprintf(buffer, "wg_muxer_stream_src_%u", stream->id);

This is supposed to have a slash in it. I'm not sure whether any element actually cares, but I'd feel more comfortable following that guideline. Probaly we should just use gst_pad_create_stream_id().

(We may also consider using appsrc instead of a bare src pad, although I don't know if it'll actually save us a significant amount work. It will take care of the start-of-stream events for us, but that's not really that much code all things considered.)