On Thu Mar 28 17:38:41 2024 +0000, Matteo Bruni wrote:
I guess it's proof that we're making serious progress with the compiler if we're starting to notice _xx version discrepancies, so good job everybody :smile: Can we add a test for this? I'd probably put it in d3dcompiler_43/tests/hlsl_d3d11.c:test_reflection(), simply checking that `GetConstantBufferByName("$Global")` returns non NULL iff D3D_COMPILER_VERSION >= 40 (which works for d3d10 since that has D3D_COMPILER_VERSION defined as 0). Second point: it's a bit annoying that this makes d3d10 import 2 versions of d3dcompiler at the same time. We can avoid that though, see the attachment. Feel free to make use of it as you prefer. [d3d10_compile.txt](/uploads/a8438df1832c3c733c56327c88023c35/d3d10_compile.txt)
Yes, that makes sense, applied.