Re: [PATCH v2 0/2] MR3397: Draft: ucrtbase: Do not modify rewind's stack arguments on i386.

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/ucrtbase/tests/misc.c:
> - {
> -
>    push [esp + 4];
> -
>    call rewind;
> -
>    pop eax;
> -
>    ret;
> - }
>
> +}
> +#endif
> -
>
> +static void test_rewind_i386_abi(void)
> +{
> - FILE *fp_in, *fp_out;
> -
> - fp_in = fopen("rewind_abi.tst", "wb");
> - fp_out = test_rewind_wrapper(fp_in);
> - todo_wine ok(fp_in == fp_out, "rewind modified the first argument in the stack\n");

Please add the test after the fix (or in the same patch). It may fail depending on wine compiler/compilation flags.