On Sun Aug 11 07:36:24 2024 +0000, Rémi Bernon wrote:
You're changing the index in keyboard_enum_objects, which doesn't match what the commit title says. Then, `keyboard_enum_objects` is called to initialize dwNumObjs, so using that member in it will simply make it not enumerate anything. Last, both `keyboard_enum_objects` loop (which hasn't been changed, so is unlikely causing a regression), and the new `keyboard_create_device` both use the exact same conditions, and I believe they are enumerating the exact same number of objects. If they weren't, the tests would also likely be crashing already. If there's a regression it's more likely related to the addition of DIPROP_SCANCODE support.
I accidentally committed the wrong change (because the loops look so similar) 🤦♀️
The tests do pass with the change in the correct place though (at least with wine-staging)