On Tue Jul 23 12:02:17 2024 +0000, Kevin Martinez wrote:
Ohhh, now I get it! I'm not sure what game is [BUG-53620](https://bugs.winehq.org/show_bug.cgi?id=53620), the ones that doesn't work for me are two visual novels by Kaeru Soft, and the demo of each tittle: [noshoujo (NSFW)(non-https)](http://www.kaeru-soft.jp/noshoujo/spe_trial.html) [nemunono (NSFW)(non-https)](http://www.kaeru-soft.jp/nemunono/dl_trial2.html) Those two are actually calling IObjectCollection, but I confused the GUID with IEnumObjects, just as @DarkShadow44 pointed out in another comment. Which means that I have another stub to add in this file. I see two options: I can scrap this submission and try again with stubs for both interfaces, resolving the other threads in the process. Or I can resolve these threads, along with the fixed GUID for **IEnumObjects**, and submit IObjectCollection later. What do you guys think? @Alcaro @DarkShadow44 P.S. The demos listed also require the IShellLink PropertyStore methods to be implemented, I believe I managed to implement it, I'm developing the tests to submit it. Meaning that on current Wine even with my patch they won't run.
If Noshoujo uses IObjectCollection, and BUG-56891's Mebae uses IEnumObjects, then yes, both should be implemented (to the degree needed for them to not crash).
Personally I'd make one MR for each game (unless they need fixes in wildly different locations and should be split further), but I have no strong feelings on that topic. If some other approach makes more sense to you, do that.
There is, however, no need to scrap anything; if this MR's scope grows, you can simply rename it.