Re: [PATCH v2 0/1] MR1884: d3d8: Filter out redundant buffer discards.

[Jan Sikorski (＠jsikorski)]

Jan Sikorski (@jsikorski) commented about dlls/d3d8/device.c:
>          wined3d_primitive_type_from_d3d(primitive_type), 0);
>  wined3d_device_apply_stateblock(device->wined3d_device, device->state);
>  wined3d_device_context_draw(device->immediate_context, start_vertex, vertex_count, 0, 0);
> -
> - for (i = 0; i < ARRAY_SIZE(device->stateblock_state->streams); ++i)
> - {
> -
>    if (device->stateblock_state->streams[i].buffer)
> -
>    {
> -
>        vb = wined3d_buffer_get_parent(device->stateblock_state->streams[i].buffer);
> -
>        vb->discarded = true;

I skipped a word in my previous comment, but I think here (and in the other draw call) it should set the flag to false? Otherwise it's always discarded? Am I missing something?