[PATCH v3 3/3] win32u: Return ERROR_ACCESS_DENIED for WH_JOURNALRECORD and WH_JOURNALPLAYBACK.

[Zhiyi Zhang]

From: Zhiyi Zhang

On > XP, settings WH_JOURNALRECORD or WH_JOURNALPLAYBACK hooks report ERROR_ACCESS_DENIED
according to tests, even with administrator rights. PCSE_TERM depends on this to not crash.
MSDN also says that journaling hooks APIs are unsupported starting in Windows 11. Reject
journalling hooks unconditionally here because they have been broken for a long time.
---
 dlls/user32/tests/msg.c |  2 --
 dlls/win32u/hook.c      | 10 ++++++++++
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
index b1be1f9ee87..6eadf324e6f 100644
--- a/dlls/user32/tests/msg.c
+++ b/dlls/user32/tests/msg.c
@@ -12299,9 +12299,7 @@ static void test_set_hook(void)
         error = GetLastError();
         if (i == WH_JOURNALRECORD || i == WH_JOURNALPLAYBACK)
         {
-            todo_wine
             ok(!hhook, "SetWinEventHook succeeded.\n");
-            todo_wine
             ok(error == ERROR_ACCESS_DENIED, "Got unexpected error %ld.\n", GetLastError());
         }
         else
diff --git a/dlls/win32u/hook.c b/dlls/win32u/hook.c
index 3cd6b1ee1a2..b9990298e0e 100644
--- a/dlls/win32u/hook.c
+++ b/dlls/win32u/hook.c
@@ -105,6 +105,16 @@ HHOOK WINAPI NtUserSetWindowsHookEx( HINSTANCE inst, UNICODE_STRING *module, DWO
         }
     }

+    /* On > XP, settings WH_JOURNALRECORD or WH_JOURNALPLAYBACK hooks report ERROR_ACCESS_DENIED
+     * according to tests, even with administrator rights. PCSE_TERM depends on this to not crash.
+     * MSDN also says that journaling hooks APIs are unsupported starting in Windows 11. Reject
+     * journalling hooks unconditionally here because they have been broken for a long time */
+    if (id == WH_JOURNALRECORD || id == WH_JOURNALPLAYBACK)
+    {
+        RtlSetLastWin32Error( ERROR_ACCESS_DENIED );
+        return 0;
+    }
+
     SERVER_START_REQ( set_hook )
     {
         req->id        = id;