On 9/12/22 07:06, Henri Verbeet (@hverbeet) wrote:
- I am not sure what the strings were before (and I don't really want to downgrade my mesa version to check, if you really want to know, I can run glxinfo on a live distro)
It would be helpful to understand what exactly changed, although perhaps not critical.
As far as I can tell it was changed (perhaps inadvertently) by Mesa commit 0cb42c57c569443b0af8296dfff4da1e6ab241ef. Previously "AMD" string would be present in the renderer string for cases where there was no marketing name (i.e. Etaash's gpu would have a GL_RENDERER value beginning with "AMD RENOIR").
As far as I can tell, radeonsi has only ever reported a GL_VENDOR of "X.org" or (more recently) "AMD", so we've been relying on "AMD" being present in the renderer string.
It may also be a good idea to try matching the card vendor based on the PCI vendor first; I imagine that will remain a bit more stable against changes like this.
- GL_VENDOR = "AMD", GL_RENDERER = "RENOIR (renoir, LLVM 14.0.6, DRM 3.47, 5.19.7-zen2-1-zen)"
- not sure, glxinfo says GLX_MESA_query_renderer is available
We may be missing an entry in `gpu_description_table[]` (in directx.c) for RENOIR. That would imply it previously wasn't getting correctly reported either though, even if it was getting reported as an AMD card instead of an NVIDIA card.
Indeed, we should add this regardless.