On Wed Jun 7 21:17:44 2023 +0000, Zebediah Figura wrote:
The problem with returning true here is that we still want this function call to return a void-typed expression. That might need to be an OP0_ERROR, which we don't have the infrastructure for yet. But as far as I can tell it should be fine to break out of the loop here, and the code should be able to handle the argument count being wrong as well without crashing either.
It seems so, but my fear is about future maintainability. I'd like the code to have as fewer "non-obvious assumptions" as possible, so that even in the future people can play with it reducing the risk of being burnt (or, say, generate misleading error messages).
If what we need is to return a void expression, then let's return a void expression.
Though if that's a problem for you I can pass on this.