Re: [PATCH v3 0/3] MR5195: ws2_32: Implement TCP_KEEPALIVE, TCP_KEEPCNT and TCP_KEEPINTVL socket options

[Florian Will (＠w-flo)]

On Fri Mar  1 09:00:50 2024 +0000, Zebediah Figura wrote:
> > Also, not sure if anything needs to be done in unix/socket.c for
>
> portability. Are these TCP_KEEPIDLE etc. constants defined on all OSes
> supported by wine? If not, how should I handle this?
> A brief search suggests that Solaris, FreeBSD, and NetBSD all have them.
> Mac has them as well, but it calls it TCP_KEEPALIVE like Windows, not
> TCP_KEEPIDLE, so we should check for that. If we do break compilation
> anywhere, I suspect it's fine to wait for a report and fix it after the fact.

I added some #ifs to hopefully make it work on Mac. I have no way to test it though, and the Mac CI runner is currently offline. So let's see. :-)