On Tue Aug 29 14:42:57 2023 +0000, Conor McCarthy wrote:
The `failed` flag is not indicative of any particular error, and while in this patch it can only be set for an invalid shader, I think making it specific and then changing it later is going a bit too far. I'd like to be able to return specific errors here but I think it will end up too complicated.
I won't insist on this because I've already argued in the past that it doesn't make too much sense to be overly specific about error codes, but overall there are some idiosyncrasies about how we handle error codes that I find confusing. Sometimes we use very specific error codes, some other times we use something very generic like in this case. Maybe `failed` shouldn't be a flag, but actually contain the error code that we have to return. Or maybe the error code should always be returned by function calls. I can lived with the current mixed approach, but I find it confusing.