22 Sep
2022
22 Sep
'22
10:36 a.m.
On Thu Sep 22 08:03:45 2022 +0000, Huw Davies wrote:
We've still got the `calloc()` here (you've changed it to a `malloc()` in a later patch). Note, not that it matters, but I'd do the `memcpy()` before appending the final `'\0'` - it seems more logical that way.
And thinking about this a bit more, this MR has got rather long. Let's create a new MR with just the first two commits from this one. Once that's in, we can come back to this one, rebase it, and get the remainder upstreamed.