Re: [PATCH 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/wmvcore/async_reader.c:
> static HRESULT WINAPI WMReaderAdvanced2_SetOutputSetting(IWMReaderAdvanced6 *iface, DWORD output_num,
>          const WCHAR *name, WMT_ATTR_DATATYPE type, const BYTE *value, WORD length)
>  {
> - struct async_reader *This = impl_from_IWMReaderAdvanced6(iface);
> - FIXME("(%p)->(%lu %s %#x %p %u)\n", This, output_num, debugstr_w(name), type, value, length);
> - return E_NOTIMPL;
> - struct async_reader *reader = impl_from_IWMReaderAdvanced6(iface);
> - struct stream *stream;
> - HRESULT hr = E_NOTIMPL;
> -
> - FIXME("reader %p, output_num %lu, name %s, type %u, value %p, length %u semi-stub!\n",
> -
>        reader, output_num, debugstr_w(name), type, value, length);

This should probably be a TRACE, and we should FIXME if name is something other than DedicatedDeliveryThread.