Re: [PATCH v4 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/effect.c:
> - int memcmp_ret;
> - HRESULT hr;
> -
> - hr = D3DXCreateEffect( device, test_set_raw_value_blob,
> -
>        sizeof(test_set_raw_value_blob), NULL, NULL, 0, NULL, &effect, NULL );
> - ok( hr == D3D_OK, "Got result %#1.1x, expected 0 (D3D_OK).\n", hr );
> -
> - /* All of these cause C0000005 on win10.  */
> - //hr = effect->lpVtbl->SetRawValue( effect, INVALID_HANDLE_VALUE, NULL, 0, 0 );
> - //ok( hr == D3DERR_INVALIDCALL, "Got result %#x, expected 0 (D3D_INVALIDCALL).\n", hr );
> - //hr = effect->lpVtbl->SetRawValue( effect, INVALID_HANDLE_VALUE, NULL, 1, 0 );
> - //ok( hr == D3DERR_INVALIDCALL, "Got result %#x, expected 0 (D3D_INVALIDCALL).\n", hr );
> - //hr = effect->lpVtbl->SetRawValue( effect, INVALID_HANDLE_VALUE, NULL, 0, 1 );
> - //ok( hr == D3DERR_INVALIDCALL, "Got result %#x, expected 0 (D3D_INVALIDCALL).\n", hr );
> - //hr = effect->lpVtbl->SetRawValue( effect, INVALID_HANDLE_VALUE, NULL, 1, 1 );
> - //ok( hr == D3DERR_INVALIDCALL, "Got result %#x, expected 0 (D3D_INVALIDCALL).\n", hr );

No C++-style comments please. We usually leave those uncommented but inside an if (0) {}, so that it's still compiled.