Nikolay Sivov (@nsivov) commented about dlls/msxml3/tests/domdoc.c:
- hr = IXMLDOMDocument_loadXML(doc, str, &b);
- ok(hr == S_OK, "Unable to load XML hr %#lx.\n", hr);
- hr = IXMLDOMDocument_get_documentElement(doc, &element);
- ok(hr == S_OK, "Unable to get element hr %#lx.\n", hr);
- hr = IXMLDOMElement_get_xml(element, &data);
- ok(hr == S_OK, "Unable to get XML hr %#lx.\n", hr);
- data_expected = SysAllocString(L"<root>\r\n"
"\t<a>\r\n"
"\t\t<b/>\r\n"
"\t</a>\r\n"
"</root>");
- ok(!lstrcmpW(data, data_expected), "incorrect element string, got '%s'\n", wine_dbgstr_w(data));
- SysFreeString(str);
- SysFreeString(data_expected);
It's fine in principle, but you don't need to allocate for expected string. Simply use a constant. The rest looks fine.