On Fri Apr 5 22:47:12 2024 +0000, Elizabeth Figura wrote:
Looks good, thanks. I'm seeing some test failures however: https://testbot.winehq.org/JobDetails.pl?Key=144685 The timeout is probably because 100 ms just isn't enough; I'd turn that up to at least 1 second. The Windows 11 failures are weirder. I've never seen the filter graph use IBaseFilter::FindPin() before and I don't know what it's being used for, but implementing it does make things basically work, at least.
A baffling error indeed. Especially considering it only shows up on that AMD VM.
I guess the AMD GPU drivers are involved somehow, and doing something silly. Didn't want to deal with refcounts and potential ref cycles, so they use the pin name, maybe. Or rather, they use the pin ID, which, for some reason, is distinct from the name.
Well, no point guessing. Let's just implement it, it's the Right Thing to do. (And let's fill in actual names and IDs, to avoid the risk of FindPin(L"") returning wrong thing on a filter with multiple pins.)
e: mixed up a few words