Re: [PATCH v2 0/4] MR1894: ntdll: heap verification improvements

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/ntdll/heap.c:
>      }
>  }
>
> - if (heap->pending_free)
> - {
> -
>    unsigned int i;
> -
> -
>    for (i = 0; i < MAX_FREE_PENDING; i++)
> -
>    {
> -
>        if (!(block = heap->pending_free[i])) break;
> -
> -
>        subheap = find_subheap( heap, block, FALSE );

You're using `find_subheap` but then it may be `NULL` if it's invalid, and you should fail early instead of using the `NULL` subheap pointer in `validate_used_block`.