Re: [PATCH v2 0/5] MR8326: ntdll: Implement RtlActivateActivationContextUnsafeFast().

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/kernel32/tests/actctx.c:
> -
>    todo_wine
> -
>    ok(status == STATUS_INVALID_PARAMETER, "Got unexpected status %#lx.\n", status);
> -
>    if (status == STATUS_SUCCESS)
> -
>    {
> -
>        b = DeactivateActCtx(0, cookie);
> -
>        ok(b, "DeactivateActCtx failed: %lu\n", GetLastError());
> -
>    }
> -
> -
>    status = pRtlActivateActivationContext(0x28, handle, &cookie);
> -
>    todo_wine
> -
>    ok(status == STATUS_INVALID_PARAMETER, "Got unexpected status %#lx.\n", status);
> -
>    if (status == STATUS_SUCCESS)
> -
>    {
> -
>        b = DeactivateActCtx(0, cookie);
> -
>        ok(b, "DeactivateActCtx failed: %lu\n", GetLastError());
> -
>    }

I don't see why we need to test this. It's good that you verified that this argument means something else, but now that we know we don't need to run it as a test. We don't use it internally and unless application is starts using it, I don't think we need to care.