Re: [PATCH v19 0/16] MR3870: mspatcha: Add support for 32-bit file patching and normalization

[Zebediah Figura (＠zfigura)]

On Tue Sep 19 18:27:47 2023 +0000, Aidan Khoury wrote:
> This is needed in case the `-Wunused-variable` is used with clang
> compiler frontend. The Windows Patch API passes this variable - see https://learn.microsoft.com/en-us/previous-versions/bb417345(v=msdn.10)#norm....
> Though it is unused, I would like to keep it to maintain compatibility
> with the Windows API.

I assume you mean -Wunused-parameter, since -Wunused-variable alone shouldn't warn on parameters.

I don't think -Wunused-parameter is reasonable to enable for Wine. The Windows API has far, far too many unused parameters for annotating them all to be worthwhile.