On Fri Nov 11 09:46:57 2022 +0000, Francisco Casas wrote:
## Regarding the code changes suggested For convenience I will write a list here of the changes suggested:
- Split `enum hlsl_base_type` into numeric and object types, and use the
`e` union in `struct hlsl_type` to handle both cases separately. Making the `dimx` and `dimy` fields only for numeric types.
- Rename `enum hlsl_type_class` to `enum hlsl_type_kind`.
- Precompute `hlsl_type_to_string()` always.
I agree with all these changes. However, the first one may require ubiquitous changes and complicate rebases, so I think we better properly coordinate for when we want to implement it. I would prefer to get most of the "broaden resources support" v2 patch series upstreamed first (I am still working on it), because it also modifies core data types, introducing ubiquious changes, and it may get complicated to upstream two of these changes at the same time. I agree in that these code changes shouldn't freeze documentation patches since, if we comment a piece of code that we will change later, the updates in the documentation will be additional information to make the commits more readable (provided we remember to do update it). This was the reason why I intented to send this patch series before "broaden resources support" v2.
Ok, it makes sense to concentrate on documentation now and leave code changes to later. Also because I am not sure they would be accepted, given that we are in code freeze.