On 8/5/22 02:01, eric pouech (@epo) wrote:
On Fri Aug 5 07:01:40 2022 +0000, Jacek Caban wrote:
I think it's ENABLE_VIRTUAL_TERMINAL_PROCESSING that we need. We could probably check if it's enabled in current mode instead. AFAIR it's enabled by default on recent Windows. It would automatically start working on Wine when we implement that in conhost then (see bug 49780).
To answer to both (Jacek's and Zebediah's comments): the first intent of the patch is not to include ANSI seq:s for color when redirecting output into a log file.
make test > test.log(and the patch works as intended - wine and windows).
Most of the comments cover adding support for colors either on windows/cmd, or wine/conhost {non unix tty output) which is another dimension.
I opted for a dedicated option in WINETEST_COLOR as some folks may want to have color ANSI seq when output is redirected into a log file.
So perhaps, you'd be happier with an alternative name to 'auto' (and updating the change log accordingly)?
I guess. It seems weird to have an "auto" option that's not actually the default state (and that doesn't work completely reliably). But it's an improvement over the current state and I don't see a reason to hold it up, so I have no objections to this patch.