8 Nov
2022
8 Nov
'22
5:37 p.m.
On Tue Nov 8 04:15:30 2022 +0000, **** wrote:
Marvin replied on the mailing list:
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=125881 Your paranoid android. === debian11 (32 bit ar:MA report) === wininet: http.c:625: Test failed: Expected position 0. Got 0xffffffff. GetLastError() 6 http.c:625: Test failed: Expected position 0x1. Got 0xffffffff. GetLastError() 6 http.c:625: Test failed: Expected position 0x2. Got 0xffffffff. GetLastError() 6 http.c:625: Test failed: Expected position 0x3. Got 0xffffffff. GetLastError() 6 http.c:632: Test failed: Expected position 0x4. Got 0xffffffff. GetLastError() 6 http.c:632: Test failed: Expected position 0x3. Got 0xffffffff. GetLastError() 6 http.c:632: Test failed: Expected position 0x2. Got 0xffffffff. GetLastError() 6 http.c:632: Test failed: Expected position 0x1. Got 0xffffffff. GetLastError() 6 http.c:656: Test failed: Expected position 0x7fffffff. Got 0xffffffff. GetLastError() 6 http.c:665: Test failed: Expected position 0x7fffffff. Got 0xffffffff. GetLastError() 6 === debian11 (32 bit hi:IN report) === wininet: http.c:625: Test failed: Expected position 0. Got 0xffffffff. GetLastError() 6 http.c:625: Test failed: Expected position 0x1. Got 0xffffffff. GetLastError() 6 http.c:625: Test failed: Expected position 0x2. Got 0xffffffff. GetLastError() 6 http.c:625: Test failed: Expected position 0x3. Got 0xffffffff. GetLastError() 6 http.c:632: Test failed: Expected position 0x4. Got 0xffffffff. GetLastError() 6 http.c:632: Test failed: Expected position 0x3. Got 0xffffffff. GetLastError() 6 http.c:632: Test failed: Expected position 0x2. Got 0xffffffff. GetLastError() 6 http.c:632: Test failed: Expected position 0x1. Got 0xffffffff. GetLastError() 6 http.c:656: Test failed: Expected position 0x7fffffff. Got 0xffffffff. GetLastError() 6 http.c:665: Test failed: Expected position 0x7fffffff. Got 0xffffffff. GetLastError() 6
The reason for those failures is that we expect tests to work after each commit. You could, for example, add todo_wines in the first patch and then remove them in the second one.
Also, it would be interesting to have tests checking the actual functionality. For example, read some data after moving the file pointer and make sure it contains expected value.