Re: [PATCH 0/5] MR1622: d3d10/effect: Add support for more instructions.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3d10/effect.c:
> -
>                return;
> -
>            }
> -
> -
>            if (FAILED(hr = d3d10_effect_preshader_eval(&d->value_expr.value)))
> -
>            {
> -
>                WARN("Failed to evaluate value expression, hr %#lx.\n", hr);
> -
>                return;
> -
>            }
> -
> -
>            table = &d->value_expr.value.reg_tables[D3D10_REG_TABLE_RESULT];
> -
> -
>            if (property_info->size > table->count)
> -
>            {
> -
>                WARN("Unexpected property size.\n");
> -
>                return;
> -
>            }

Would it make sense to broaden this check to property_info->size != table->count?

Also we could probably print the sizes (especially table->count) in the message.