Re: [PATCH 0/8] MR396: vkd3d-shader/hlsl: Support non-constant offset dereferences, v2, part 1.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_codegen.c:
>      struct hlsl_block idx_block;
>
>      if (!(offset = new_offset_from_path_index(ctx, &idx_block, type, offset, deref->path[i].node,
> -
>            regset, loc)))
> -
>            regset, offset_component, loc)))
> -
>    {
> -
>        hlsl_block_cleanup(&idx_block);

Good to cleanup the node, but my feeling is that should be done at the same level it is initialized, i.e., inside `new_offset_from_path_index()`. To me keeping a consistent convention makes it easier to spot problems. Don't know what the others think about that. Another good option is to also initialize the block outside of `new_offset_from_path_index()`.