1 Aug
2022
1 Aug
'22
8:57 a.m.
On Sun Jul 31 18:36:31 2022 +0000, Tobias G��rgens wrote:
I'll do that, should I also split the two implementations? I don't know how helpful that would be as a) both happen in the same file and b) GetDllVersion depends on DllGetVersion. What do you think?
It's generally wanted to only have "atomic" changes per commit, so it's easier to bisect if an issue arises in the future. So put everything into a commit that is introducing an independent feature change / new feature. So yeah, put both implementations in separate commits as well. Regarding the tests, you can mark stuff, which is going to be fixed by a future commit, with `todo_wine`. So commit tests first and the impl afterwards.