On Fri Jan 27 02:06:46 2023 +0000, Mohamad Al-Jaf wrote:
changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/2045/diffs?diff_id=29561&start_sha=9397ad318ef261b75bf883d02a625fc5b2fab31f#18155e07203db2f01e8679483563c2d99221479b_35_35)
I believe it's extern on Windows as there is no header for the prototype so it needs external linkage. I'm not sure if it should also be explicitly set as extern in Wine. AFAIK, extern is default in the C compiler anyway.
Though, I missed the const part.
D3D12Core is part of the DirectX Agility SDK. The dll is supposed to be shipped with games. Typically, games check the Windows version rather than the D3D12Core version to determine which is newer and subsequently which to use. However, in this case the game is directly checking for the existence of the dll. So returning the lowest version should make games use their shipped dll.