22 May
2025
22 May
'25
8:59 p.m.
On Thu May 22 20:00:31 2025 +0000, Alexandre Julliard wrote:
I don't think you should be changing %r14 here. It's also not clear why resetting %ss is necessary, where does it get cleared?
Do you mean my comment in the patch is unclear or the explanation in MR is unclear? Which one should I adjust? Without %ss reload (after a syscall), any AMD (Ryzen, ThreadRipper, etc) machine would crash with something like `addr = f7f0, signo = 11, code = 1, trapno = 12` (`RSP = 0x12f7f0`) as soon as it switches to the protected mode, meaning it operates in some kind of 16-bit mode for the stack (don't know what it is, don't care either).