On Thu Dec 14 15:56:17 2023 +0000, Henri Verbeet wrote:
+ if (dst[0].reg.data_type == VKD3D_DATA_UINT64) + uint_max_id =
spirv_compiler_get_constant_uint64_vector(compiler, 0xffffffffffffffff, component_count);
I don't think "0xffffffffffffffff" is portable/reliable as a 64-bit constant. We should probably use "UINT64_C(0xffffffffffffffff)", although you could probably make a case for either "UINT64_MAX" or "~(uint64_t)0" as well.
I'd vote for one of the last two, which are already used widely in the code base. Specifically, `UINT64_MAX` is my favourite.