Re: [PATCH 0/4] MR1681: uxtheme: Avoid using lstrcmpiW.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/stylemap.c:
> -/**********************************************************************
> -
> -
>  MSSTYLES_LookupProperty
> -
> -
> -
> - Find a property ID from name
> -
> -
> -
> - PARAMS
> -
> -
> pszPropertyName     Name of property to lookup
> -
> -
> dwPrimitive         Location to store primitive type of property
> -
> -
> dwId                Location to store ID of property
> -
> -
> -
> - RETURNS
> -
> -
> FALSE if value is not found, TRUE otherwise
> - */
>
> -BOOL MSSTYLES_LookupProperty(LPCWSTR pszPropertyName, int *dwPrimitive, int *dwId)
> +/* prop_name must be upper case */
> +BOOL MSSTYLES_LookupProperty(const WCHAR *prop_name, int *primitive, int *id)

I think it's better to do the upper-case conversion inside MSSTYLES_LookupProperty() in the case. So the people calling this function don't have to bother about case matching.