On Fri Aug 2 21:07:38 2024 +0000, Matteo Bruni wrote:
Sooo, when I proposed this in the previous review I was figuring that `D3DX_DEFAULT` handling could go in the helper as well, although I didn't exactly consider that `D3DXFilterTexture()` has its own different interpretation of `D3DX_DEFAULT`. What do you think about introducing yet another helper to be used in everything-but-`D3DXFilterTexture()` which does D3DX_DEFAULT handling and also calls `d3dx9_validate_filter()`? E.g. something like `HRESULT d3dx9_handle_load_filter(D3DX_FILTER *filter);`
Changed this in the current revision. There's no `D3DX_FILTER` type, so I've just used `DWORD` which is what all the filter values are.
I've also re-ordered the patches a bit due to the introduction of this separate helper. Let me know if this is better. :)