On Wed Nov 29 17:23:08 2023 +0000, Rémi Bernon wrote:
I don't think this has ever been like that on winex11 and it is actually the opposite: XSync and XFlush have always been frowned upon and avoided unless explicitly required. The XSync addition here was meant only to synchronize *before* calling XDestroyWindow, and I'd keep it like that until we have an evidence that it's needed *after* XReparentWindow (which should be confirmed soon enough and be a trivial change).
Not sure about soon enough, given it obviously won't affect every app, given how fun is to debug X sync issues, especially when you can't reproduce that because your setup is just a bit different and issues are random, when it doesn't crash with XBadWindow but rather misbehaves with some wrong size when going fullscreen or out due to some intermediate resize, and as best it will be blamed to a commit which does other thing not directly concerning such synchronization. But if there are reasons to think XSync on reparenting is expensive enough, well, ok.