On Wed Sep 4 13:22:56 2024 +0000, Rémi Bernon wrote:
Uh, no? The macro isn't used yet, but it will be later. I could've split it differently but i don't think it matters so much.
X64 means the argument struct is different for 32bit and 64bit callers, and needs to be converted if the caller is 32bit and callee is 64bit (aka new-style wow64). In practice, this is means 'does the argument struct contain any pointers or pointer-sized objects?'.
These don't. One just contains a char array, and the other isn't used at all.
So, no, these should not be X64. The unused macro looks a little silly, but every other wow64_funcs table in other unixlibs has the same macro; removing it would be inconsistent, which is also silly.
And, as mentioned, it will be used later.