On Tue Apr 1 15:28:29 2025 +0000, Paul Gofman wrote:
[test.patch](/uploads/9a6536295ba63cb61806540eb24351a5/test.patch) The attached test (on top of my patches) shows that refs in the structure at least is not size_t, I was testing something like that initially. I should probably get the constructor arguments back but change refs in the structure in the implementation? It doesn't affect much because the structure is aligned anyway.
This change will break similar test in msvcp90: ```diff diff --git a/dlls/msvcp90/tests/ios.c b/dlls/msvcp90/tests/ios.c index 91da0b91dd8..eb4febeb57b 100644 --- a/dlls/msvcp90/tests/ios.c +++ b/dlls/msvcp90/tests/ios.c @@ -2586,7 +2586,9 @@ static void test_time_get__Getint(void) time_get_char time_get; int i, ret, v;
+ memset(&time_get, 0xcc, sizeof(time_get)); call_func1(p_time_get_char_ctor, &time_get); + trace("--> %Ix\n", time_get.facet.refs); ```
It looks like locale_facet was changed but only in msvcp140 version (I didn't check anything except msvcp90 and msvcp140, what version it changed in needs to be verified).