Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY

[Zhiyi Zhang (＠zhiyi)]

On Thu Oct 31 10:21:42 2024 +0000, Alanas wrote:
> do `ok`s in
>         case forward_test_code:
>             if (forward_test)
>             {
>                 ok(hdr == &forward_test_nmhdr, "Got unexpected header.\n");
>                 ok(wParam == forward_test_idFrom, "Got unexpected wParam
> 0x%Ix.\n", wParam);
>             }
>             else
>             {
>                 ok(FALSE, "Got unexpected WM_NOTIFY.\n");
>             }
>             forward_test = FALSE;
>             return forward_test_return;
>
> need to be replaced with `todo_wine ok`?
> they get passed 1 in first argument in windows and never run in wine
> without editing `dlls/comctl32/toolbar.c`

If these ok() in parent_wnd_notify() don't have failures before your fix, then you don't need to add todo_wines in parent_wnd_notify().