Re: [PATCH v3 0/2] MR8689: dwrite: Implement dwritefactory3_GetFontDownloadQueue().

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/dwrite/main.c:
> -
> - if (IsEqualGUID(iid, &IID_IUnknown) || IsEqualGUID(iid, &IID_IDWriteFontDownloadQueue))
> - {
> -
>    *out = iface;
> -
>    IDWriteFontDownloadQueue_AddRef(iface);
> -
>    return S_OK;
> - }
> -
> - *out = NULL;
> - WARN("%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid(iid));
> - return E_NOINTERFACE;
>
> +}
> -
>
> +static ULONG WINAPI dwritefontdownloadqueue_AddRef(IDWriteFontDownloadQueue *iface)
> +{
> - struct dwritefactory *impl = impl_from_IDWriteFontDownloadQueue(iface);

We don't use such naming anywhere else in this module. Please call it 'factory' instead.