On Wed Nov 22 18:12:33 2023 +0000, Rémi Bernon wrote:
The tests use 32bit WMA input type (which is probably incorrect but it is accepted), and this makes us return 32bit PCM output, which is also incorrect and doesn't pass the tests (at mf/tests/transform.c:3590). Maybe better change the tests to avoid using an arguably invalid input type and solve this issue while keeping support for more than 16bit with WMA3.
Oh, so that's what zf's testbot run was complaining about.
Plenty of float32 in that file, but that specific one is MEDIASUBTYPE_WMAUDIO2, which can only be 16. Fixed, good catch.
Also fixed 32bit a little more; https://learn.microsoft.com/en-us/windows/win32/api/mmreg/ns-mmreg-waveforma... says PCM can only be 8 or 16 bits, and if it's 32, it's float.
(quartz_parser.c amt_from_wg_format_audio emits WAVE_FORMAT_EXTENSIBLE for float data, but I'll just use WAVE_FORMAT_IEEE_FLOAT until someone tests it properly.)