Re: [PATCH v7 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour

[eric pouech (＠epo)]

eric pouech (@epo) commented about dlls/ntdll/tests/directory.c:
> -
>    goto done;
> - }
> - InitializeObjectAttributes(&attr, &ntdirname, OBJ_CASE_INSENSITIVE, 0, NULL);
> -
> - /* Open a handle for our test directory */
> - status = pNtOpenFile(&dirh, SYNCHRONIZE | FILE_LIST_DIRECTORY, &attr, &io, FILE_SHARE_READ,
> -
>                     FILE_SYNCHRONOUS_IO_NONALERT | FILE_OPEN_FOR_BACKUP_INTENT | FILE_DIRECTORY_FILE);
> - ok( status == STATUS_SUCCESS, "failed to open dir '%s', ret 0x%lx, error %ld\n", testdir, status, GetLastError() );
> - if (status != STATUS_SUCCESS)
> - {
> -
>   skip("can't test if we can't open the directory\n");
> -
>   goto done;
> - }
> -
> - /* Open a handle for our test directory to test multiple handles */
> - status = pNtOpenFile(&dirh_test_multiple_handles, SYNCHRONIZE | FILE_LIST_DIRECTORY, &attr, &io, FILE_SHARE_READ,

nitpick: for readibility of the tests, you'd rather move that close to the part of the tests where you use the created handle