Re: [PATCH 0/3] MR749: vkd3d-shader/ir: Minimise temp usage.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/ir.c:
> -
>                for (j = data_false->phi_begin; j < data_false->phi_begin + data_false->phi_count; ++j)
> -
>                {
> -
>                    const struct vkd3d_shader_src_param *source;
> -
> -
>                    source = materialize_ssas_to_temps_compute_source(&program->instructions.elements[j],
> -
>                            current_label);
> -
>                    if (!materialize_ssas_to_temps_synthesize_mov(program, &instructions[ins_count],
> -
>                            &ins->location, &program->instructions.elements[j].dst[0], cond, source, true))
> -
>                        goto fail;
> -
> -
>                    ++ins_count;
> -
>                }
> -
>                struct phi_incoming_to_temp *incoming = &info->incomings[j];
> -
> -
>                mov_ins = &instructions[ins_count++];
> -
>                vsir_instruction_init_with_params(program, mov_ins, &ins->location, VKD3DSIH_MOV, 1, 0);

This can fail.