On Tue Feb 14 18:41:43 2023 +0000, Zebediah Figura wrote:
I think it'd be better to test that the render target contains inf/nan, unless that differs or is impossible for some reason. I have tests in my local tree that do that for sm4 at least.
I don't know if "require" ends up a correct name for this
functionality, shader does not require specific version, results do. Limiting to >= 4.0 is also insufficient, because that does not show the difference with SM3 and below, which takes absolute value of the input internally. Eh, yeah, although [require] can be put anywhere, e.g. before the [test] block. It's maybe not the best name, but it doesn't seem awful; the point is just to restrict the platforms we run those tests on, for whatever reason.
Yes, having actual values in expected results is better, if it's reliable. Require could mean "restrict to", so it's not bad. I can probably add support for "< 4.0" if that does not work already, and use that for d3d9.