On Fri Jun 23 18:14:11 2023 +0000, Rémi Bernon wrote:
Since https://gitlab.winehq.org/wine/wine/-/merge_requests/3126 and https://gitlab.winehq.org/wine/wine/-/merge_requests/3138 have been merge I don't think this has any actual effect. I have been removing these DECLSPEC in the past in several places, I don't think there's any reason to add them back.
The situation is much improved now thanks to you and Jacek, thank you!
As far as I can tell, the only remaining effect of the visibility hidden attribute is to omit the refptr symbols when compiling 32-bit PE modules with Clang. It seems to me that the utility of the visibility hidden attribute hinges on whether or not LLVM will give us another way to omit those symbols. Gabriel found an LLVM merge request to remove them, but it hasn't been touched since 2019. I've poked the LLVM maintainers and hopefully they'll be able to shed some more light on the topic.