Re: [PATCH v5 0/7] MR3189: Add windows.devices.geolocation.geolocator

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/windows.devices.geolocation.geolocator/main.c:
> -
>
> +static ULONG WINAPI weak_reference_Release(IWeakReference *iface)
> +{
> - struct geolocator *impl = impl_from_IWeakReference(iface);
> - ULONG ref = InterlockedDecrement(&impl->ref_weak);
> - if (ref == 0)
> - {
> -
>    free(impl);
> - }
> - return ref;
>
> +}
> -
>
> +static HRESULT WINAPI weak_reference_Resolve(IWeakReference *iface, REFIID iid, IInspectable **ref)
> +{
> - struct geolocator *impl = impl_from_IWeakReference(iface);
> - TRACE("iface %p, ref %p stub.\n", iface, ref);

You should trace the iid here.