On Tue Apr 23 00:28:58 2024 +0000, Elizabeth Figura wrote:
That's impossible; "buffer" is of length MAX_PATH. If we're going to overrun the buffer then SetupGetStringFieldW() would have failed anyway.
This conditional FIXME was there already, so no change here (other than the local variable rename).
But now that I just wrote that, I think I got what you mean and **what this conditional FIXME was used for previously**.
So this FIXME was never about detecting overruns, because the overrun was impossible also previously. But it's point is to issue a warning that `MAX_PATH` might not be enough to capture the whole value of the key, i.e. if there was a risk to get a truncated value; if the buffer gets completely filled, it's possible that part of the value got left out.
But now, `SetupGetStringFieldW` parses the whole value and checks if the buffer is actually big enough to store it, so indeed, this FIXME is completely redundant.